basic test, move views to views.rs, exempt from authz test

nexus/src/external_api/http_entrypoints.rs

@@ -366,17 +366,6 @@ pub fn external_api() -> NexusApiDescription {
 // clients. Client generators use operationId to name API methods, so changing
 // a function name is a breaking change from a client perspective.
 
-#[derive(Clone, Debug, Eq, PartialEq, Serialize, JsonSchema)]
-#[serde(rename_all = "snake_case")]
-enum SystemHealthStatus {
-    Ok,
-}
-
-#[derive(Clone, Debug, Eq, PartialEq, Serialize, JsonSchema)]
-struct SystemHealth {
-    status: SystemHealthStatus,
-}
-
 /// Get API status
 ///
 /// Always tries to return Ok. If the API is down, it will either 500 or time out.
@@ -387,8 +376,10 @@ struct SystemHealth {
 }]
 async fn system_health(
     _rqctx: RequestContext<Arc<ServerContext>>,
-) -> Result<HttpResponseOk<SystemHealth>, HttpError> {
-    Ok(HttpResponseOk(SystemHealth { status: SystemHealthStatus::Ok }))
+) -> Result<HttpResponseOk<views::SystemHealth>, HttpError> {
+    Ok(HttpResponseOk(views::SystemHealth {
+        status: views::SystemHealthStatus::Ok,
+    }))
 }
 
 /// Fetch the top-level IAM policy

nexus/tests/integration_tests/basic.rs

@@ -13,7 +13,8 @@ use http::StatusCode;
 use omicron_common::api::external::IdentityMetadataCreateParams;
 use omicron_common::api::external::IdentityMetadataUpdateParams;
 use omicron_common::api::external::Name;
-use omicron_nexus::external_api::{params, views::Project};
+use omicron_nexus::external_api::params;
+use omicron_nexus::external_api::views::{self, Project};
 use serde::Serialize;
 use uuid::Uuid;
 
@@ -546,3 +547,13 @@ async fn test_projects_list(cptestctx: &ControlPlaneTestContext) {
             .collect::<Vec<Uuid>>()
     );
 }
+
+#[nexus_test]
+async fn test_system_health(cptestctx: &ControlPlaneTestContext) {
+    let client = &cptestctx.external_client;
+
+    let health = NexusRequest::object_get(client, "/v1/system/health")
+        .execute_and_parse_unwrap::<views::SystemHealth>()
+        .await;
+    assert_eq!(health.status, views::SystemHealthStatus::Ok);
+}

nexus/tests/integration_tests/endpoints.rs

@@ -1874,6 +1874,5 @@ lazy_static! {
                 AllowedMethod::GetNonexistent
             ],
         },
-
     ];
 }

nexus/tests/output/uncovered-authz-endpoints.txt

@@ -1,4 +1,5 @@
 API endpoints with no coverage in authz tests:
+system_health                            (get    "/v1/system/health")
 device_auth_request                      (post   "/device/auth")
 device_auth_confirm                      (post   "/device/confirm")
 device_access_token                      (post   "/device/token")

nexus/types/src/external_api/views.rs

@@ -522,3 +522,16 @@ pub struct UpdateDeployment {
     pub version: SemverVersion,
     pub status: UpdateStatus,
 }
+
+// SYSTEM HEALTH
+
+#[derive(Clone, Debug, Eq, PartialEq, Serialize, Deserialize, JsonSchema)]
+#[serde(rename_all = "snake_case")]
+pub enum SystemHealthStatus {
+    Ok,
+}
+
+#[derive(Clone, Debug, Eq, PartialEq, Serialize, Deserialize, JsonSchema)]
+pub struct SystemHealth {
+    pub status: SystemHealthStatus,
+}