Skip to content

Commit

Permalink
Comment on why we're increasing recv_buf
Browse files Browse the repository at this point in the history
  • Loading branch information
wfchandler committed Oct 1, 2024
1 parent c7a2b55 commit 552d1c5
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions illumos-utils/src/ipadm.rs
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,14 @@ impl Ipadm {
/// Set TCP recv_buf to 1 MB.
pub fn set_tcp_recv_buf() -> Result<(), ExecutionError> {
let mut cmd = std::process::Command::new(PFEXEC);

// This is to improve single-connection throughput on large uploads
// from clients, e.g., images. Modern browsers will almost always use
// HTTP/2, which will multiplex concurrent writes to the same host over
// a single TCP connection. The small default receive window size is a
// major bottleneck, see
// https://github.com/oxidecomputer/console/issues/2096 for further
// details.
let cmd = cmd.args(&[
IPADM,
"set-prop",
Expand Down

0 comments on commit 552d1c5

Please sign in to comment.