Skip to content

Commit

Permalink
[wicket] Add hostname and purpose checks to uploaded SSL certs (#4086)
Browse files Browse the repository at this point in the history
This is a rework of #3436; I think it's enough different that it
warrants a separate review. Many of the comments on the previous PR were
on the bits where I was implementing the checks; this version leans much
more heavily on OpenSSL to do those checks.

This addresses the initial bit of #4045 (validating names on certs prior
to RSS), but not the full bit: we should also validate names when
creating silos. That didn't look completely trivial to plumb through, so
I left a `TODO` and will try to tackle that in a followup PR.
  • Loading branch information
jgallagher authored Sep 14, 2023
1 parent aceb744 commit 22a0179
Show file tree
Hide file tree
Showing 13 changed files with 621 additions and 116 deletions.
14 changes: 11 additions & 3 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ expectorate = "1.0.7"
fatfs = "0.3.6"
flate2 = "1.0.27"
flume = "0.11.0"
foreign-types = "0.3.2"
fs-err = "2.9.0"
futures = "0.3.28"
gateway-client = { path = "gateway-client" }
Expand Down
7 changes: 7 additions & 0 deletions certificates/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,14 @@ edition = "2021"
license = "MPL-2.0"

[dependencies]
display-error-chain.workspace = true
foreign-types.workspace = true
openssl.workspace = true
openssl-sys.workspace = true
thiserror.workspace = true

omicron-common.workspace = true

[dev-dependencies]
omicron-test-utils.workspace = true
rcgen.workspace = true
Loading

0 comments on commit 22a0179

Please sign in to comment.