Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add first-class support for topological sorting #56

Closed
smklein opened this issue Jan 12, 2024 · 1 comment · Fixed by #57
Closed

Add first-class support for topological sorting #56

smklein opened this issue Jan 12, 2024 · 1 comment · Fixed by #57

Comments

@smklein
Copy link
Collaborator

smklein commented Jan 12, 2024

Currently, omicron-package requires callers to uncover their own topological sorting: oxidecomputer/crucible#1097

This could be improved, by adding a function to the shared omicron-package crate to perform this sorting for clients.
@smklein
Copy link
Collaborator Author

smklein commented Jan 12, 2024

This feature is a huge boon, all credit to @luqmana for adding it back in Omicron, but I realized Crucible needed it too. I can look into generalizing this support a bit.

This was referenced Jan 12, 2024
Merged
Merged
smklein added a commit that referenced this issue Jan 15, 2024
@smklein
Add support for calculating build order (#57)
d9361a7 
This is basically oxidecomputer/crucible#1097 , but generalized and with tests

Adds support for topologically sorting packages, so they can be built in dependency-first order.

Fixes #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for calculating build order oxidecomputer/omicron-package
1 participant
@smklein