make usdt an optional dependency (#354)

oxidecomputer · May 20, 2022 · b4ca959 · b4ca959
1 parent 53106a8
commit b4ca959
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 18 deletions.
diff --git a/dropshot/Cargo.toml b/dropshot/Cargo.toml
@@ -60,6 +60,7 @@ features = [ "full" ]
 
 [dependencies.usdt]
 version = "0.3.2"
+optional = true
 default-features = false
 
 [dependencies.uuid]

diff --git a/dropshot/src/lib.rs b/dropshot/src/lib.rs
@@ -578,6 +578,7 @@ pub(crate) struct ResponseInfo {
     message: String,
 }
 
+#[cfg(feature = "usdt-probes")]
 #[usdt::provider(provider = "dropshot")]
 mod probes {
     use crate::{RequestInfo, ResponseInfo};

diff --git a/dropshot/src/server.rs b/dropshot/src/server.rs
@@ -162,25 +162,26 @@ impl<C: ServerContext> HttpServerStarter<C> {
         };
         info!(self.app_state.log, "listening");
 
-        let probe_registration = if cfg!(feature = "usdt-probes") {
-            match usdt::register_probes() {
-                Ok(_) => {
-                    debug!(
-                        self.app_state.log,
-                        "successfully registered DTrace USDT probes"
-                    );
-                    ProbeRegistration::Succeeded
-                }
-                Err(e) => {
-                    let msg = e.to_string();
-                    error!(
-                        self.app_state.log,
-                        "failed to register DTrace USDT probes: {}", msg
-                    );
-                    ProbeRegistration::Failed(msg)
-                }
+        #[cfg(feature = "usdt-probes")]
+        let probe_registration = match usdt::register_probes() {
+            Ok(_) => {
+                debug!(
+                    self.app_state.log,
+                    "successfully registered DTrace USDT probes"
+                );
+                ProbeRegistration::Succeeded
             }
-        } else {
+            Err(e) => {
+                let msg = e.to_string();
+                error!(
+                    self.app_state.log,
+                    "failed to register DTrace USDT probes: {}", msg
+                );
+                ProbeRegistration::Failed(msg)
+            }
+        };
+        #[cfg(not(feature = "usdt-probes"))]
+        let probe_registration = {
             debug!(
                 self.app_state.log,
                 "DTrace USDT probes compiled out, not registering"