Use zx over a shell script for the export icons process #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Also managed to fix the issue with the regex wiping out some icons — tweaked so it's a little less greedy. |
benjaminleonard
added
patch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@benjaminleonard hit up against some platform differences with
sedwhich was causing the export script to fail.I decided to take a bit of a different approach here and use a tool called
zxand practice some literate programming. Instead of a shell script, there's now a markdown file that's compiled into a.mjsfile and executed byzx.In practice it results in the same thing, it's just tweaked a bit to make certain parts easier to reason about.