[workspace-hack] use workspace-dotted format and a patch directive #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
mkeeter
approved these changes
Oct 4, 2023
leftwo
reviewed
Oct 4, 2023
Created using spr 1.3.4
sunshowers
deleted the
sunshowers/spr/workspace-hack-use-workspace-dotted-format-and-a-patch-directive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to oxidecomputer/omicron#4197, this PR
has two changes:
Switch to the workspace-dotted format (
.workspace = true) foruniformity with the rest of crucible. This is new in cargo-hakari
0.9.28.
Use a patch directive, which means that the workspace-hack only
applies while building within this workspace. If another workspace
imports a crate from here via a git dependency, it will not have the
workspace-hack applied to it (instead, it will use this empty crate
on crates.io). Thanks so much to @pfmooney for this
suggestion!