Add early rejection of IOs if too many Downstairs are inactive #1565
Conversation
|
Some random musings around this. If we send the write to one downstairs, it could land on disk, but the IO will sit waiting for another downstairs to write it before we could ACK back to the guest. Any flush is going to stop all future IOs, as they will all build up behind it. This is actually a reason to fast fail writes/flushes as I believe that would enable reads to still work, right? What should we do with in-flight IOs? Do we now want to discard them as well? If we do fail outstanding IOs, outstanding writes we would have already fast-acked, but flushes will now go to failed. By doing this, are we cutting off a chance for a replay to catch things up? |
No, writes are either fast-acked to the guest or (after changes made in this PR) fast-errored. In the latter case, they aren't sent to any Downstairs.
Yes, with caveats – if the Guest is waiting for a flush, then sending a read, it would previously stall if 2x Downstairs are offline. Now, the flush will return an error immediately, and the read can proceed (or not, depending on how the Guest handles error codes).
This PR hasn't changed any behavior here. If a Downstairs goes to the Faulted state, all of its IOs are skipped, which may cause them to be acked to the Guest.
No, any IO rejected here is never added to the active jobs list, so it's never sent to any downstairs. It's rejected before being assigned a |
Ah yes, fast ack will ack while it thinks things are good. If one downstairs is online, it could get the data and the other two would not, but we have already acked it back to the guest.
The transition to faulted here, that's what I think I needed to see, so that will skip IO to any downstairs in
So, your right that a replay does not happen here. I'm thinking about |
| self.clients | ||
| .iter() | ||
| .filter(|c| { | ||
| matches!(c.state(), DsState::Active | DsState::LiveRepair) |
There was a problem hiding this comment.
I think we need to allow additional states here. Offliine for instance is one where we have not yet decided what the situation is, and it could just be a downstairs rebooting and soon enough (fingers crossed) it will come back.
There may be other transitory states to consider as well.
There was a problem hiding this comment.
If this goes in before 1568/1570, then we want the updated list of DsState's
There was a problem hiding this comment.
It's going to be much easier to rebase this onto #1577 then vice versa, so I think we should get those three merged before thinking about this further!
This aborts the IO before passing it to the Downstairs, so it's not assigned a
JobIdor put into theActiveJobsmap. The most noticeable change is that writes are now fast-err'd instead of fast-acked if > 1 Downstairs is inactive.