Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target replacement support for VCRs with multiple sub_volumes #1551

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Target replacement support for VCRs with multiple sub_volumes #1551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
53e1211
Target replacement support for VCRs with multiple sub_volumes
leftwo Nov 5, 2024
ef074fc
Backout un-needed generation bump
leftwo Nov 7, 2024
733b511
No clone needed
leftwo Nov 7, 2024
2032eea
Make an enum for ROP states
leftwo Nov 7, 2024
ab9e022
Helper function to make sub-volumes
leftwo Nov 7, 2024
1949ae7
subvolume helpers
leftwo Nov 8, 2024
f755325
A test_all for ReadOnlyParentMode
leftwo Nov 11, 2024
667489f
Merge branch 'main' into alan/vcr-with-sub-volumes
leftwo Nov 18, 2024
5e02f0d
Merge branch 'main' into alan/vcr-with-sub-volumes
Dec 20, 2024
2e2ea36
Bail don't panic when comparing unsupported VCRs
leftwo Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions integration_tests/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5701,7 +5701,7 @@ mod test {
let new_vol = VolumeConstructionRequest::Volume {
id: sv_volume_id,
block_size: BLOCK_SIZE as u64,
sub_volumes: new_sub_vol.clone(),
sub_volumes: new_sub_vol,
read_only_parent: Some(rop),
};

Expand All @@ -5715,6 +5715,14 @@ mod test {
let new_downstairs = tds.new_downstairs().await.unwrap();
info!(log, "A New downstairs: {:?}", new_downstairs.address());

let more_sub_vol = vec![VolumeConstructionRequest::Region {
block_size: BLOCK_SIZE as u64,
blocks_per_extent: sv_tds.blocks_per_extent(),
extent_count: sv_tds.extent_count(),
opts: sv_opts.clone(),
gen: 3,
}];

let mut new_opts = tds.opts().clone();
new_opts.target[0] = new_downstairs.address();
info!(log, "Old ops target: {:?}", opts.target);
Expand All @@ -5732,7 +5740,7 @@ mod test {
let replacement = VolumeConstructionRequest::Volume {
id: sv_volume_id,
block_size: BLOCK_SIZE as u64,
sub_volumes: new_sub_vol.clone(),
sub_volumes: more_sub_vol,
read_only_parent: Some(new_rop),
};

Expand Down
Loading
Loading