-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client authn verification page #929
Conversation
@plotnick is attempting to deploy a commit to the Oxide Computer Company Team on Vercel. To accomplish this, @plotnick needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
Forgot to mention, this looks great. You can join the console team any time |
console won’t automatically generate the new api client for you. you have to run |
Yeah. I'm getting an error generating the new api here, but weirdly not in
|
I’ll take a look. Most likely the easy fix will be to rename a struct in omicron. |
# Conflicts: # OMICRON_VERSION
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
It was as I expected. Slightly embarrassing for oxide.ts, honestly. I'm going to fix it properly so this doesn't happen anymore, but there's a quick fix in oxidecomputer/omicron#1303. There was a type named and we generate types for those by default. But the generator also constructs its own type with the same name out of the method called So the quick fix in that PR is to rename |
In df04b09 I generated the client with |
d69946c
to
a3e9007
Compare
# Conflicts: # OMICRON_VERSION # libs/api/__generated__/OMICRON_VERSION
Sweeeet! Thanks! |
Depends on Omicron#1194 and oxidecomputer/oxide.ts#119.