E2E tests with Playwright #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview will be deployed at https://console-git-playwright.internal.oxide.computer |
david-crespo
force-pushed
the
playwright
branch
from
80f4e5f
to
7985250
Compare
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/oxidecomputer/console-ui-storybook/7dfdCd6iicfafXz85PVWr1FRvPHu |
david-crespo
force-pushed
the
playwright
branch
from
7985250
to
f429511
Compare
david-crespo
force-pushed
the
playwright
branch
from
f429511
to
19131b7
Compare
david-crespo
force-pushed
the
playwright
branch
from
19131b7
to
513ef77
Compare
david-crespo
force-pushed
the
playwright
branch
from
8665cfc
to
277c435
Compare
david-crespo
force-pushed
the
playwright
branch
from
277c435
to
d3fee20
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running into very annoying performance issues trying to do what with Testing Lib and JSDOM what would really be better done in Cypress and Playwright, I decided to try the latter. The results are quite good.
Two features that I want very much have been given the
1.20(next version) label by the maintainers:Now, 59 issues have that label, so they might not all make it into the next version, but hopefully it'll be soon.
I experimented with
playwright-testing-libraryto get *ByRole queries, but I couldn't get it to work without some really ugly syntax.This doesn't really need to be its own job, but this allows it to run in parallel with the other tests. The yarn install, the Playwright install, and the tests take a minute each. It would be nice to cache both
yarn installand the Playwright browser install, but it's perfectly fine without that.