Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateway route links to router instead of route edit form #2622

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Gateway route links to router instead of route edit form #2622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/pages/project/vpcs/internet-gateway-edit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,15 @@ function RouteRows({ project, vpc, gateway }: PP.VpcInternetGateway) {

return matchingRoutes.map(([router, route]) => (
<Table.Row key={route.id}>
<Table.Cell className="!bg-raise">{router}</Table.Cell>
<Table.Cell className="bg-raise">
<Table.Cell className="!bg-raise">
<Link
to={pb.vpcRouterRouteEdit({ project, vpc, router, route: route.name })}
to={pb.vpcRouter({ project, vpc, router })}
className="link-with-underline text-sans-md"
>
{route.name}
{router}
</Link>
</Table.Cell>
<Table.Cell className="!bg-raise">{route.name}</Table.Cell>
</Table.Row>
))
}
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/vpcs.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,9 +408,9 @@ test('internet gateway shows proper list of routes targeting it', async ({ page
await expect(table.locator('tbody >> tr')).toHaveCount(2)

// click on the new-route link to go to the detail page
await sidemodal.getByRole('link', { name: 'new-route' }).click()
await sidemodal.getByRole('link', { name: 'mock-custom-router' }).first().click()
// expect to be on the view page
await expect(page).toHaveURL(
'/projects/mock-project/vpcs/mock-vpc/routers/mock-custom-router/routes/new-route/edit'
'/projects/mock-project/vpcs/mock-vpc/routers/mock-custom-router'
)
})
Loading