Add table row action to copy silo ID from system utilization page #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Great. The diff with whitespace hidden is extremely short. Nice about FF supporting the clipboard tests. Only thing I'd like to see is a doc comment on the RowActions component and/or the id and label props saying something like
If
idis provided, a copy ID menu item will be automatically included. UsecopyIdLabelto override the default label.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Sep 16, 2024
oxidecomputer/console@7712765...ce242e7 * [ce242e77](oxidecomputer/console@ce242e77) bump API to latest, only doc comment changes * [3fda42e3](oxidecomputer/console@3fda42e3) oxidecomputer/console#2446 * [a5c23616](oxidecomputer/console@a5c23616) oxidecomputer/console#2436 * [ca272336](oxidecomputer/console@ca272336) oxidecomputer/console#2445 * [22582e3c](oxidecomputer/console@22582e3c) oxidecomputer/console#2444 * [f9f0d157](oxidecomputer/console@f9f0d157) oxidecomputer/console#2443 * [be84c196](oxidecomputer/console@be84c196) oxidecomputer/console#2441 * [53e1da78](oxidecomputer/console@53e1da78) chore: just skip the flaky test in safari * [3a66ca77](oxidecomputer/console@3a66ca77) bump a couple of dev deps I missed * [ac67a4cf](oxidecomputer/console@ac67a4cf) bump omicron version to latest * [63c604b4](oxidecomputer/console@63c604b4) oxidecomputer/console#2440 * [b4e2626b](oxidecomputer/console@b4e2626b) oxidecomputer/console#2439 * [cdecf4e6](oxidecomputer/console@cdecf4e6) oxidecomputer/console#2435 * [01d71c07](oxidecomputer/console@01d71c07) oxidecomputer/console#2432 * [353b98d6](oxidecomputer/console@353b98d6) oxidecomputer/console#2404 * [49d6d7d8](oxidecomputer/console@49d6d7d8) oxidecomputer/console#2433 * [9c532ce9](oxidecomputer/console@9c532ce9) chore: fix react duplicate key warning on vpcs page * [1892fc14](oxidecomputer/console@1892fc14) npm audit fix, bump msw * [efc43be0](oxidecomputer/console@efc43be0) oxidecomputer/console#2422 * [f2cc79ee](oxidecomputer/console@f2cc79ee) oxidecomputer/console#2418 * [a0c29a53](oxidecomputer/console@a0c29a53) oxidecomputer/console#2427 * [a8fcdab9](oxidecomputer/console@a8fcdab9) oxidecomputer/console#2426 * [8ecb36ad](oxidecomputer/console@8ecb36ad) oxidecomputer/console#2425 * [93bcef9d](oxidecomputer/console@93bcef9d) oxidecomputer/console#2296 * [af42e704](oxidecomputer/console@af42e704) oxidecomputer/console#2421 * [4126f000](oxidecomputer/console@4126f000) oxidecomputer/console#2420 * [880cb8c4](oxidecomputer/console@880cb8c4) oxidecomputer/console#2415 * [c2909e7a](oxidecomputer/console@c2909e7a) oxidecomputer/console#2414 * [12fc862b](oxidecomputer/console@12fc862b) oxidecomputer/console#2412 * [169edeed](oxidecomputer/console@169edeed) remove unreachable sign in button in user dropdown * [f042ad4b](oxidecomputer/console@f042ad4b) oxidecomputer/console#2409 * [c648c44c](oxidecomputer/console@c648c44c) oxidecomputer/console#2408 * [e8175d30](oxidecomputer/console@e8175d30) oxidecomputer/console#2405 * [bdb55b86](oxidecomputer/console@bdb55b86) chore: bump ts client generator version in api-diff * [681355cd](oxidecomputer/console@681355cd) oxidecomputer/console#2396 * [286b8d28](oxidecomputer/console@286b8d28) oxidecomputer/console#2401 * [b2373359](oxidecomputer/console@b2373359) oxidecomputer/console#2400 * [267b9359](oxidecomputer/console@267b9359) oxidecomputer/console#2399
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Sep 16, 2024
oxidecomputer/console@7712765...ce242e7 * [ce242e77](oxidecomputer/console@ce242e77) bump API to latest, only doc comment changes * [3fda42e3](oxidecomputer/console@3fda42e3) oxidecomputer/console#2446 * [a5c23616](oxidecomputer/console@a5c23616) oxidecomputer/console#2436 * [ca272336](oxidecomputer/console@ca272336) oxidecomputer/console#2445 * [22582e3c](oxidecomputer/console@22582e3c) oxidecomputer/console#2444 * [f9f0d157](oxidecomputer/console@f9f0d157) oxidecomputer/console#2443 * [be84c196](oxidecomputer/console@be84c196) oxidecomputer/console#2441 * [53e1da78](oxidecomputer/console@53e1da78) chore: just skip the flaky test in safari * [3a66ca77](oxidecomputer/console@3a66ca77) bump a couple of dev deps I missed * [ac67a4cf](oxidecomputer/console@ac67a4cf) bump omicron version to latest * [63c604b4](oxidecomputer/console@63c604b4) oxidecomputer/console#2440 * [b4e2626b](oxidecomputer/console@b4e2626b) oxidecomputer/console#2439 * [cdecf4e6](oxidecomputer/console@cdecf4e6) oxidecomputer/console#2435 * [01d71c07](oxidecomputer/console@01d71c07) oxidecomputer/console#2432 * [353b98d6](oxidecomputer/console@353b98d6) oxidecomputer/console#2404 * [49d6d7d8](oxidecomputer/console@49d6d7d8) oxidecomputer/console#2433 * [9c532ce9](oxidecomputer/console@9c532ce9) chore: fix react duplicate key warning on vpcs page * [1892fc14](oxidecomputer/console@1892fc14) npm audit fix, bump msw * [efc43be0](oxidecomputer/console@efc43be0) oxidecomputer/console#2422 * [f2cc79ee](oxidecomputer/console@f2cc79ee) oxidecomputer/console#2418 * [a0c29a53](oxidecomputer/console@a0c29a53) oxidecomputer/console#2427 * [a8fcdab9](oxidecomputer/console@a8fcdab9) oxidecomputer/console#2426 * [8ecb36ad](oxidecomputer/console@8ecb36ad) oxidecomputer/console#2425 * [93bcef9d](oxidecomputer/console@93bcef9d) oxidecomputer/console#2296 * [af42e704](oxidecomputer/console@af42e704) oxidecomputer/console#2421 * [4126f000](oxidecomputer/console@4126f000) oxidecomputer/console#2420 * [880cb8c4](oxidecomputer/console@880cb8c4) oxidecomputer/console#2415 * [c2909e7a](oxidecomputer/console@c2909e7a) oxidecomputer/console#2414 * [12fc862b](oxidecomputer/console@12fc862b) oxidecomputer/console#2412 * [169edeed](oxidecomputer/console@169edeed) remove unreachable sign in button in user dropdown * [f042ad4b](oxidecomputer/console@f042ad4b) oxidecomputer/console#2409 * [c648c44c](oxidecomputer/console@c648c44c) oxidecomputer/console#2408 * [e8175d30](oxidecomputer/console@e8175d30) oxidecomputer/console#2405 * [bdb55b86](oxidecomputer/console@bdb55b86) chore: bump ts client generator version in api-diff * [681355cd](oxidecomputer/console@681355cd) oxidecomputer/console#2396 * [286b8d28](oxidecomputer/console@286b8d28) oxidecomputer/console#2401 * [b2373359](oxidecomputer/console@b2373359) oxidecomputer/console#2400 * [267b9359](oxidecomputer/console@267b9359) oxidecomputer/console#2399
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a column to the
system/utilizationpage, allowing users to copy the ID of the silo on each row. As this table is constructed a bit differently than our other tables where we pass the columns in, I extracted some existing code into a RowActions component that we can call independently (as we do in this PR). The new component also has an optional prop forcopyIdLabel, in case we want to use more specific copy than "Copy ID" (as we do in this PR).Closes #2344
Minor sidenote: We had an existing "did it copy to the clipboard?" test that was skipping for Safari and Firefox. It's still uncooperative for CI contexts, but Firefox is now working, as of June 2024, so we aren't skipping that one any more.