Add/remove IP ranges #1930
Merged
Add/remove IP ranges #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
commented
Feb 5, 2024
| // like a pain | ||
|
|
||
| return errors ? { values: {}, errors } : { values, errors: {} } | ||
| } |
There was a problem hiding this comment.
It turns out writing a custom resolver to validate multiple fields together is very easy. We could do this more often. The only problem is that I think it can't be used with other kinds of validation. For example, I think the required prop below is being ignored because of this resolver. In this case, that's fine because empty string is not valid IP, so we catch it here.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 5, 2024
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1603
Closes #1937
The most interesting part is the IP range validation. I manually confirmed that Rust's
std::netconsiders the same IPs valid and invalid as my regexes:https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=babc49cd34bf19669137e22b9202d2eb
2024-02-04-ip-range-form.mp4