Remove formik Field components from UI layer #1064
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we first started integrating Formik into the console we really didn't have much of a separation between the UI of a form element and its actual logical behavior. Given that, we added the
Field
component in our form UI components. This has a few downsides:This tight coupling has already caused a few minor issues. I'm working on richer table selection behavior to address #1060 and I ran into it but it's not the first time I've ran across it.
Also, we've got #804 where we're actively considering migrating away from Formik. This would be the first required step either way.