Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge access policies #1041

Closed
wants to merge 1 commit into from
Closed

Merge access policies #1041

wants to merge 1 commit into from

Conversation

david-crespo
Copy link
Collaborator

@david-crespo david-crespo commented Jul 7, 2022

This is about #1024, but it is equally likely to end up as fuel for me to ask the API to do this as it is to end up merged.

@vercel
Copy link

vercel bot commented Jul 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
console-ui-storybook ✅ Ready (Inspect) Visit Preview Jul 7, 2022 at 8:13PM (UTC)

Comment on lines +52 to +54
const { data: orgPolicy } = useApiQuery('organizationPolicyView', {
orgName: projectParams.orgName,
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a user doesn't have permissions for this, what would happen?

Copy link
Collaborator Author

@david-crespo david-crespo Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question! That could happen if they lacked the read permission on the org (you can read the policy if you can read the resource), and they would not be able to see any permissions that are inherited from the org. The best we could do is not error and maybe say "there may be other people who are are getting access through the org, but you can't see the org so we can't tell you".

This is another argument against doing this client-side, possibly also an argument for tweaking the permissions model.

@david-crespo
Copy link
Collaborator Author

Closing for now. API needs discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants