Include gzipped version of assets in console tarball #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
commented
Jul 5, 2022
| @@ -26,6 +26,8 @@ jobs: | |||
| - run: yarn install | |||
| - name: Build for Nexus | |||
| run: SHA=${{ github.sha }} yarn build-for-nexus | |||
| - name: Gzip individual files (keep originals) | |||
| run: ls dist/assets/*.{js,css,map} | xargs gzip --keep | |||
david-crespo
commented
Jul 5, 2022
| - name: Copy files to main.* | ||
| run: | | ||
| cp releases/console/${{ github.sha }}.tar.gz releases/console/main.tar.gz | ||
| cp releases/console/${{ github.sha }}.sha256.txt releases/console/main.sha256.txt |
There was a problem hiding this comment.
99% sure nobody was using this, for reasons indicated by the changes to serve-from-nexus.md — ./tools/install_prerequisites.sh in Omicron handles the whole thing for you and it points to a commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console side of oxidecomputer/omicron#1345. I tried it locally, but need to change the workflow file to run on this PR (instead of only main) to confirm that it works in a GH action.
The
serve-from-nexus.mdchanges aren't really relevant to the change, I had just been meaning to do it and used the instructions when testing locally.I'm only gzipping
.js,.map, and.cssfiles. According to this, unlike other font file types,woffare already compressed so you should not compress them.