gateway route links to router instead of route edit form

oxidecomputer · Dec 13, 2024 · f1e8e55 · f1e8e55
1 parent 1dd25f6
commit f1e8e55
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/app/pages/project/vpcs/internet-gateway-edit.tsx b/app/pages/project/vpcs/internet-gateway-edit.tsx
@@ -37,9 +37,7 @@ import {
 
 const RoutesEmpty = () => (
   <Table.Row>
-    <Table.Cell colSpan={2} className="!bg-raise">
-      No VPC router routes target this gateway.
-    </Table.Cell>
+    <Table.Cell colSpan={2}>No VPC router routes target this gateway.</Table.Cell>
   </Table.Row>
 )
 
@@ -51,15 +49,15 @@ function RouteRows({ project, vpc, gateway }: PP.VpcInternetGateway) {
 
   return matchingRoutes.map(([router, route]) => (
     <Table.Row key={route.id}>
-      <Table.Cell className="!bg-raise">{router}</Table.Cell>
-      <Table.Cell className="bg-raise">
+      <Table.Cell className="!bg-raise">
         <Link
-          to={pb.vpcRouterRouteEdit({ project, vpc, router, route: route.name })}
+          to={pb.vpcRouter({ project, vpc, router })}
           className="link-with-underline text-sans-md"
         >
-          {route.name}
+          {router}
         </Link>
       </Table.Cell>
+      <Table.Cell className="!bg-raise">{route.name}</Table.Cell>
     </Table.Row>
   ))
 }

diff --git a/test/e2e/vpcs.e2e.ts b/test/e2e/vpcs.e2e.ts
@@ -408,9 +408,9 @@ test('internet gateway shows proper list of routes targeting it', async ({ page
   await expect(table.locator('tbody >> tr')).toHaveCount(2)
 
   // click on the new-route link to go to the detail page
-  await sidemodal.getByRole('link', { name: 'new-route' }).click()
+  await sidemodal.getByRole('link', { name: 'mock-custom-router' }).first().click()
   // expect to be on the view page
   await expect(page).toHaveURL(
-    '/projects/mock-project/vpcs/mock-vpc/routers/mock-custom-router/routes/new-route/edit'
+    '/projects/mock-project/vpcs/mock-vpc/routers/mock-custom-router'
   )
 })