Skip to content

Commit

Permalink
remove unrelated EmptyCell change
Browse files Browse the repository at this point in the history
  • Loading branch information
charliepark committed Dec 18, 2024
1 parent a40237f commit c2406cd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions app/table/cells/InstanceLinkCell.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { useApiQuery } from '@oxide/api'
import { useProjectSelector } from '~/hooks/use-params'
import { pb } from '~/util/path-builder'

import { EmptyCell, SkeletonCell } from './EmptyCell'
import { SkeletonCell } from './EmptyCell'
import { LinkCell } from './LinkCell'

export const InstanceLinkCell = ({ instanceId }: { instanceId?: string }) => {
Expand All @@ -23,7 +23,7 @@ export const InstanceLinkCell = ({ instanceId }: { instanceId?: string }) => {
)

// has to be after the hooks because hooks can't be executed conditionally
if (!instanceId) return <EmptyCell />
if (!instanceId) return null
if (!instance) return <SkeletonCell />

return (
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/disks.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ test('List disks and snapshot', async ({ page }) => {
state: 'attached',
})
await expectRowVisible(table, {
'Attached to': '',
'Attached to': '',
name: 'disk-3',
size: '6 GiB',
state: 'detached',
Expand Down

0 comments on commit c2406cd

Please sign in to comment.