Skip to content

Commit

Permalink
Fix issue where empty IP on a NIC is submitted as an empty string (#1811
Browse files Browse the repository at this point in the history
)

* Fix issue where empty IP on a NIC is submitted as an empty string

* regen client with another oxide.ts fix

---------

Co-authored-by: David Crespo <[email protected]>
  • Loading branch information
zephraph and david-crespo authored Dec 4, 2023
1 parent 5e11fd8 commit 9e82f9a
Show file tree
Hide file tree
Showing 4 changed files with 41 additions and 32 deletions.
2 changes: 1 addition & 1 deletion app/forms/network-interface-create.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { useForm, useProjectSelector } from 'app/hooks'
const defaultValues: InstanceNetworkInterfaceCreate = {
name: '',
description: '',
ip: '',
ip: undefined,
subnetName: '',
vpcName: '',
}
Expand Down
31 changes: 16 additions & 15 deletions libs/api/__generated__/msw-handlers.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 23 additions & 15 deletions libs/api/__generated__/validate.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tools/generate_api_client.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ GEN_DIR="$PWD/libs/api/__generated__"

# this will be less horrific when the package is published? or maybe not
npm run --silent --prefix ../oxide.ts gen-from $OMICRON_SHA $GEN_DIR
npx prettier --write --loglevel error "$GEN_DIR"
npx prettier --write --log-level error "$GEN_DIR"

# hack until we start pulling this from npm. we don't want this file
rm "$GEN_DIR/type-test.ts"
Expand Down

0 comments on commit 9e82f9a

Please sign in to comment.