actually the problem was the node cache

oxidecomputer · Dec 10, 2024 · 988d7dc · 988d7dc
1 parent 397fd6d
commit 988d7dc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/.github/workflows/lintBuildTest.yml b/.github/workflows/lintBuildTest.yml
@@ -20,7 +20,7 @@ jobs:
         id: cache-node-modules
         with:
           path: node_modules
-          key: modules-${{ hashFiles('package-lock.json') }}
+          key: modules-${{ hashFiles('package-lock.json') }}-${{ hashFiles('patches/**') }}
       - name: npm install
         if: steps.cache-node-modules.outputs.cache-hit != 'true'
         run: npm install
@@ -39,7 +39,7 @@ jobs:
         id: cache-node-modules
         with:
           path: node_modules
-          key: modules-${{ hashFiles('package-lock.json') }}
+          key: modules-${{ hashFiles('package-lock.json') }}-${{ hashFiles('patches/**') }}
       - name: Typecheck
         run: npx tsc
       - name: Lint
@@ -67,7 +67,7 @@ jobs:
         uses: actions/cache@v4
         with:
           path: node_modules
-          key: modules-${{ hashFiles('package-lock.json') }}
+          key: modules-${{ hashFiles('package-lock.json') }}-${{ hashFiles('patches/**') }}
       - name: Set env.PLAYWRIGHT_VERSION
         run: |
           PLAYWRIGHT_VERSION=$(npm ls --json @playwright/test | jq --raw-output '.dependencies["@playwright/test"].version')

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -39,7 +39,6 @@
     "@radix-ui/react-dialog": "^1.0.5",
     "@radix-ui/react-focus-guards": "1.0.1",
     "@radix-ui/react-tabs": "^1.1.0",
-    "@radix-ui/react-use-escape-keydown": "^1.1.0",
     "@react-aria/live-announcer": "^3.3.4",
     "@react-spring/web": "^9.7.4",
     "@tanstack/react-query": "^5.56.2",