remove ExternalLink component used in one spot

oxidecomputer · Jul 3, 2024 · 01d6158 · 01d6158
1 parent 00b7602
commit 01d6158
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 32 deletions.
diff --git a/app/components/DocsPopover.tsx b/app/components/DocsPopover.tsx
@@ -13,25 +13,25 @@ import { OpenLink12Icon, Question12Icon } from '@oxide/design-system/icons/react
 
 import { buttonStyle } from '~/ui/lib/Button'
 
-import { ExternalLink } from './ExternalLink'
-
 type DocsPopoverLinkProps = {
   href: string
   linkText: string
 }
 
 export const DocsPopoverLink = ({ href, linkText }: DocsPopoverLinkProps) => (
-  <ExternalLink
+  <a
     href={href}
-    className="group block px-4 no-underline children:last:border-0"
+    className="group block px-4 children:last:border-0"
+    target="_blank"
+    rel="noreferrer"
   >
     <div className="mx-2 border-b py-1.5 border-secondary">
       <div className="relative -ml-2 inline-block rounded py-1 pl-2 pr-7 text-sans-md !text-default group-hover:bg-tertiary">
         <span className="inline-block max-w-[300px] truncate align-middle">{linkText}</span>
         <OpenLink12Icon className="absolute top-1.5 ml-2 translate-y-[1px] text-tertiary" />
       </div>
     </div>
-  </ExternalLink>
+  </a>
 )
 
 type DocsPopoverProps = {

diff --git a/app/components/ExternalLink.tsx b/app/components/ExternalLink.tsx