Remove execution for connection manager #52
Conversation
Sounds good, I'll wait until presubmit CI goes green.
I really thought I remembered other crates doing this, but I can't find other good examples where "the pool also implements the connection type". https://docs.rs/diesel/latest/diesel/prelude/trait.Connection.html is implemented on "Connection" types, that aren't pools. I took some inspiration from https://docs.rs/bb8-diesel/ when building this crate, and there, https://docs.rs/bb8-diesel/0.2.1/bb8_diesel/struct.DieselConnectionManager.html does not implement the |
- Accesses the DB via connections explicitly, rather than using a pool - This change reduces generics slightly, and simplifies error handling. Callers can deal with "pool errors" when checking out the connection, and can deal with "query errors" separately when issuing the queries themselves. Depends on oxidecomputer/async-bb8-diesel#52 Fixes #4132
Previously
AsyncConnectionwas implemented for both connections and for the pool itself. This meant the query execution functions (i.e.,execute_async(...)) could act on either a pool or a connection.ConnectionErrorerrors from queries to connections, orPoolErrorerrors from queries to pools (which is basicallyConnectionError+ Any error from checking out the connection).Now
AsyncConnectionis implemented for connections, not pools. This should unify error handling for callers, and hopefully make the access to individual DB connections a little more obvious.Part of oxidecomputer/omicron#4132