Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify connection-related error messages #43

Merged
merged 2 commits into from
May 26, 2023
Merged

Conversation

davepacheco
Copy link
Collaborator

While doing oxidecomputer/omicron#3232 I found the error message for connection-related errors always says that it was checking out a connection, but that isn't necessarily true. As far as I can tell, this variant is used in two places:

I'm changing the variant name and error message here to just say that this was a connection-related error.

@davepacheco
Copy link
Collaborator Author

See oxidecomputer/omicron#3233 for examples.

@davepacheco davepacheco requested a review from bnaecker May 26, 2023 03:32
@davepacheco davepacheco merged commit be3d9bc into master May 26, 2023
@davepacheco davepacheco deleted the dap/error-message branch May 26, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants