-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRD mainnet adaptations #514
Conversation
49b48e0
to
c397592
Compare
c397592
to
5fba7fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When do the values get deep merged?
- name: report-uploader | ||
image: {{ .Values.tezos_k8s_images.snapshotEngine }} | ||
volumeMounts: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this is always run even if none of the aws and bucket vals are set
When you pass custom values.yaml with TRD config, it gets merged with this dummy default config that was in the yaml. It's best to put nothing and let the user set the entire config in custom values.ayml |
ah understood. How about leaving the properties as actual values but leaving them empty or with empty strings for example. Especially for properties that must be set to indicate to the user they must set them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome. looks good. i'm assuming it works
I deployed TRD against a mainnet baker with tezos-k8s and found a few missing parameters from the original work. Adding them.
Also, I am commenting out by default the TRD params in values.yaml, otherwise they get deep-merged by helm, which yields odd results.
I am also adding the option to upload the resulting data from trd to a bucket. Since TRD runs in a cronjob, it's hard to shell into it to look at the files. Uploading the entire PVC to a bucket is a nice substitute.