-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/null deletion edge case #34
Conversation
What would be the impact of this for the katG deletion? |
][-1] | ||
> nc_num | ||
): | ||
return None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it easy to add a test case for this just to make sure there aren't any off by one errors, or something like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not particularly easy to add a test case for this - it'd either have to be a new dummy genome or a contrived TB test case (slow). However, it shouldn't be off by one as >
should be checking that the calculated nc_num
is less than the minimum gene position
This should result in 0 changes to the prediction, but should change the
This gives a null value for |
Give
None
for gene position in cases where the start of a deletion in a revcomp gene goes past the start of the gene's promoter