fix: check clashes within get_calls #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcolpus
force-pushed
the
check_clashes_post_filter
branch
from
e55c857 to
c91e98d
Compare
mcolpus
force-pushed
the
check_clashes_post_filter
branch
from
c8bca14 to
80de97d
Compare
JeremyWesthead
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many rows of the vcf (filtered or ref calls) get ignored within get_calls.
So you could instead check for clashes after that filtering has occured.
This helps for sundial which often marks rows as filtered, rather than removing them
plus a bit of formatting