Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read/write problems to JSON files #111

Merged
merged 5 commits into from
May 28, 2024
Merged

Read/write problems to JSON files #111

merged 5 commits into from
May 28, 2024

Conversation

goulart-paul
Copy link
Member

Adds a "serde" option enabling read/write of problem data to a JSON file. The output to this file will be the unscaled problem data and settings, but written after any presolve or chordal decomposition steps are applied. To get an exact copy of what the solver first received, it is necessary to disable those options before writing.

Implements wrappers for these read/write functions in both the internal ClarabelRs julia wrapper and for the python wrappers.

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.30%. Comparing base (192fa0b) to head (6734765).
Report is 3 commits behind head on main.

Files Patch % Lines
src/solver/implementations/default/json.rs 97.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   86.56%   87.30%   +0.74%     
==========================================
  Files          78       76       -2     
  Lines        6058     6050       -8     
==========================================
+ Hits         5244     5282      +38     
+ Misses        814      768      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goulart-paul goulart-paul changed the base branch from main to develop May 28, 2024 18:26
@goulart-paul goulart-paul merged commit da5546c into develop May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant