Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why not add --legacy option to realize start instead of specified in .realize.yaml file #160

Closed
DarthPestilane opened this issue Jan 25, 2018 · 3 comments
Closed

Why not add --legacy option to realize start instead of specified in .realize.yaml file #160

DarthPestilane opened this issue Jan 25, 2018 · 3 comments
Assignees
@asoseil
Labels
Improvement
Milestone
3.0

Comments

@DarthPestilane
Copy link
Contributor

DarthPestilane commented Jan 25, 2018 •
edited
Loading

Consider it as a suggestion.

Sometimes we want to do realize start --nc --run in a container of docker. But when we modify the code, realize won't detect the change, thanks to the limitations of fsnotify#55. So we have to specify using legacy watch in .realize.yaml file.

Realize is a wonderful tool for golang development. I'm wondering whether realize can support realize start --legacy option in order to specify using legacy watch but without a config file.

Thanks.
@asoseil
Copy link
Contributor

asoseil commented Jan 25, 2018 •
edited
Loading

yeah, it seems a good idea, I'll add this suggestion to next release. 1 second by default could be ok?

@asoseil asoseil self-assigned this Jan 25, 2018
@asoseil asoseil added this to the 2.1 milestone Jan 25, 2018
@DarthPestilane
Copy link
Contributor Author

@asoseil That will be perfect. Thanks.

asoseil added a commit that referenced this issue Feb 8, 2018
@asoseil
#160 fixed
e1ec6e4
@asoseil asoseil closed this as completed Feb 8, 2018
asoseil added a commit that referenced this issue Apr 14, 2018
@asoseil
Merge pull request #176 from oxequa/develop
13ee93c 
#156 #175 #160
@shane151
Copy link

shane151 commented Aug 2, 2018

Please update the docs/README.md for this option.

I didn't realise it existed until I found this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asoseil asoseil

Labels
Improvement
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
3 participants
@asoseil @shane151 @DarthPestilane