Number of small Xcode 16 build fixes #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mpretty-cyro
commented
Sep 24, 2024
mpretty-cyro
commented
- Renamed an init which matched a private API so triggered a store submission warning
- Fixed a unit test build issue in Xcode 16
- Updated the LintLocalizableStrings updatePermissionStrings output to be sorted (so it doesn't change every time)
- Moved the 'Ensure InfoPlist.xcstrings updated' build step to the Session target
• Renamed an init which matched a private API so triggered a store submission warning • Fixed a unit test build issue in Xcode 16 • Updated the LintLocalizableStrings updatePermissionStrings output to be sorted (so it doesn't change every time) • Moved the 'Ensure InfoPlist.xcstrings updated' build step to the Session target
RyanRory
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.