Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for userconfig PR 2 #2810

Merged
merged 4 commits into from
Jul 10, 2023
Merged

fix for userconfig PR 2 #2810

merged 4 commits into from
Jul 10, 2023

Conversation

Bilb
Copy link
Collaborator

@Bilb Bilb commented Jul 7, 2023

No description provided.

@Bilb Bilb changed the title fix: notif settings in list item convoId from contextprovider fix for userconfig PR 2 Jul 7, 2023
@Bilb Bilb force-pushed the fix-userconfig2 branch 2 times, most recently from 28c3965 to c347e77 Compare July 7, 2023 13:47
yougotwill
yougotwill requested changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@yougotwill yougotwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to add the avatar icon that iOS and Android use as a fallback for when the pubkey is undefined when generating the closegroup avatar.

@Bilb Bilb merged commit ec620d0 into oxen-io:unstable Jul 10, 2023
@Bilb Bilb deleted the fix-userconfig2 branch August 9, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yougotwill yougotwill yougotwill requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bilb @yougotwill