Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(linter/no-unused-vars): use default IgnorePattern when /^_/ is provided as a pattern #6697

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DonIsaac
Copy link
Collaborator

@DonIsaac DonIsaac commented Oct 20, 2024

Use IgnorePattern::Default even when /^_/ is explicitly provided as a regex. This gives better diagnostic messages and lets us use starts_with('_') in more cases.

Copy link

graphite-app bot commented Oct 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

DonIsaac commented Oct 20, 2024

@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Oct 20, 2024
@DonIsaac DonIsaac marked this pull request as ready for review October 20, 2024 03:17
Copy link

codspeed-hq bot commented Oct 20, 2024

CodSpeed Performance Report

Merging #6697 will not alter performance

Comparing don/10-19-perf_linter/no-unused-vars_use_default_ignorepattern_when_/__/_is_provided_as_a_pattern (159fe13) with main (85e69a1)

Summary

✅ 30 untouched benchmarks

@DonIsaac DonIsaac added the 0-merge Merge with Graphite Merge Queue label Oct 20, 2024
Copy link
Collaborator Author

DonIsaac commented Oct 20, 2024

Merge activity

  • Oct 20, 12:24 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 20, 12:28 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 20, 12:28 AM EDT: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.

@DonIsaac DonIsaac force-pushed the don/10-19-feat_linter/eslint_show_ignore_patterns_in_eslint/no-unused-vars_diagnostic_messages branch from 6289632 to 01a35bb Compare October 20, 2024 04:24
Base automatically changed from don/10-19-feat_linter/eslint_show_ignore_patterns_in_eslint/no-unused-vars_diagnostic_messages to main October 20, 2024 04:28
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants