refactor(allocator): make Box::new_in code more explicit
#4432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
Dunqing
force-pushed
the
07-23-refactor_allocator_rename_fn_params_for_box_new_in_
branch
from
e4a0264
to
504daed
Compare
Dunqing
approved these changes
Jul 23, 2024
Dunqing
changed the base branch from
07-23-refactor_allocator_rename_fn_params_for_box_new_in_
to
main
Dunqing
force-pushed
the
07-23-refactor_allocator_make_box_new_in_code_more_explicit
branch
from
b81c84d
to
3c0673b
Compare
CodSpeed Performance ReportMerging #4432 will not alter performanceComparing Summary
|
Merge activity
|
Replace `.into` with `NonNull::from`. I feel this is a bit clearer.
Dunqing
force-pushed
the
07-23-refactor_allocator_make_box_new_in_code_more_explicit
branch
from
3c0673b
to
0677a91
Compare
graphite-app
bot
deleted the
07-23-refactor_allocator_make_box_new_in_code_more_explicit
branch
eryue0220
added a commit
to eryue0220/oxc
that referenced
this pull request
Jul 24, 2024
…0/oxc into feat/vitest-no-import-node-test * 'feat/vitest-no-import-node-test' of github.com:eryue0220/oxc: Release crates v0.22.0 (oxc-project#4434) feat(syntax): add boolean check methods for typescript-related symbol flags (oxc-project#4426) refactor(allocator): make `Box::new_in` code more explicit (oxc-project#4432) refactor(allocator): rename fn params for `Box::new_in` (oxc-project#4431) ci: pass secret to reusable workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
.intowithNonNull::from. I feel this is a bit clearer.