New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(semantic): remove a branch from `add_scope` #4384

Merged

graphite-app merged 1 commit into main from 07-21-perf_semantic_remove_a_branch_from_add_scope_

Jul 21, 2024

Commits on Jul 21, 2024

perf(semantic): remove a branch from add_scope (#4384 )

Similar to #4361.

`ScopeTree::add_scope` had a branch specifically to handle `Program`. Remove that by inlining the special logic for `Program` into `visit_program`.

Probably won't have much effect on benchmarks as the branch is easy to predict, but still removes a few instructions and makes `add_scope` easier for compiler to inline.

overlookmotel committed Jul 21, 2024