Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use fs::canonicalize to cover symlink edge cases #284

Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Oct 22, 2024

fixes #263

@Boshen
Copy link
Member Author

Boshen commented Oct 22, 2024

Setting up test case is too difficult, but I've verified in the repro https://github.com/NicholasLYang/oxc-repro

just example /Users/boshen/github/oxc-repro ./apps/web/nm/@repo/typescript-config/index.js

path: "/Users/boshen/github/oxc-repro"
specifier: ./apps/web/nm/@repo/typescript-config/index.js
Resolved: "/Users/boshen/github/oxc-repro/nm/index.js"

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.05%. Comparing base (ee87dbc) to head (5455a98).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   97.03%   97.05%   +0.01%     
==========================================
  Files          11       11              
  Lines        2363     2378      +15     
==========================================
+ Hits         2293     2308      +15     
  Misses         70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Oct 22, 2024

CodSpeed Performance Report

Merging #284 will not alter performance

Comparing 10-22-fix_use_fs_canonicalize_to_cover_symlink_edge_cases (5455a98) with main (ee87dbc)

Summary

✅ 3 untouched benchmarks

@Boshen Boshen enabled auto-merge (squash) October 22, 2024 06:09
@Boshen Boshen merged commit f2252a8 into main Oct 22, 2024
21 checks passed
@Boshen Boshen deleted the 10-22-fix_use_fs_canonicalize_to_cover_symlink_edge_cases branch October 22, 2024 06:10
This was referenced Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken nested and relative symlinks
1 participant