Update sapling_balances_match for Transaction v5 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
- Quote from the spec - Explain why the function is redunant for v5 - Rename the function so it's clear that it is sapling-specific
teor2345
force-pushed
the
sapling-balances-match
branch
from
c9d90d0 to
acd86ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
sapling_balances_matchis correct for Transaction v5, but we still need to quote from the spec, and explain why it is correct.Solution
The code in this pull request has:
Review
@oxarbitrage can review and merge into ZcashFoundation#2047 when he is ready.