fix(rpc): ignore non-standard "jsonrpc = 1.0" in lightwalletd requests #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
lightwalletd
sends a "jsonrpc: 1.0" field in its RPC requests. But this field was only added in JSON-RPC 2.0, sojsonrpc_core
rejects it.Specifications
jsonrpc field:
http://www.simple-is-better.org/rpc/#differences-between-1-0-and-2-0
Valid jsonrpc_core versions:
https://docs.rs/jsonrpc-core/18.0.0/jsonrpc_core/types/request/struct.MethodCall.html#structfield.jsonrpc
https://docs.rs/jsonrpc-core/18.0.0/jsonrpc_core/types/version/enum.Version.html
Solution
Based on ZcashFoundation#3589
Review
I'd like both @oxarbitrage and @jvff to have a look at this fix.
This fix doesn't have tests yet, but I've tested it manually.
Reviewer Checklist
Follow Up Work
lightwalletd
instance