Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with mypy 0.990 #65

Closed
wants to merge 1 commit into from

Conversation

intgr
Copy link
Contributor

@intgr intgr commented Nov 10, 2022

Fixes #64, as discussed at python/mypy#14029

@oxan
Copy link
Owner

oxan commented Nov 10, 2022

I was literally fixing this right now 😂

I'll keep 27cd263 if you don't mind, as it's identical except for the comment. Thanks anyway!

@intgr
Copy link
Contributor Author

intgr commented Nov 10, 2022

Haha no problem. Thanks!

@intgr intgr closed this Nov 10, 2022
@intgr intgr deleted the fix-compatibility-with-mypy-0.990 branch November 10, 2022 20:18
@intgr
Copy link
Contributor Author

intgr commented Nov 15, 2022

I hope this fix can be released this week 🐶

@oxan
Copy link
Owner

oxan commented Nov 15, 2022

Sure, I can put a release out this weekend.

@oxan
Copy link
Owner

oxan commented Nov 18, 2022

@intgr I've just pushed v1.2.0 :)

@intgr
Copy link
Contributor Author

intgr commented Nov 19, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mypy error: Type argument "X" of "DataclassSerializer" must be a subtype of "Dataclass"
2 participants