Fix cross-compilation #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxalica
requested changes
May 18, 2021
|
Can you provide the shell.nix or flake.nix for you cross-compiling environment? |
abbec
force-pushed
the
cross-compile-fixes
branch
2 times, most recently
from
8b4f70a to
9c36018
Compare
|
It is part of a larger Nix framework (that is not yet open source) so it is a little bit tricky |
abbec
force-pushed
the
cross-compile-fixes
branch
from
9c36018 to
fafdc7f
Compare
|
Seems to work fine with just changing where the dependencies are specified, sorry for making more changes than needed |
|
I can fix the commit message to better reflect the changes |
abbec
force-pushed
the
cross-compile-fixes
branch
from
fafdc7f to
8d530ee
Compare
oxalica
approved these changes
May 18, 2021
Dependencies were specified in `depsTargetTarget` which would make them end up in the dependencies for the target platform when they are actually dependencies needed on the buildPlatform using the rust package. I.e. they are target dependencies of the compiler package but will be used as build platform dependencies when propagated.
abbec
force-pushed
the
cross-compile-fixes
branch
from
8d530ee to
70fc350
Compare
|
I also added a comment explaining WTH is going on :). Thanks for your time and sorry for being stubborn (and wrong)! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like there has been a mixup on what the build, host and target platforms are. To
quote the Nixpkgs manual: "In summary, build is the platform on which a package is being
built, host is the platform on which it will run. The third attribute, target, is relevant
only for certain specific compilers and build tools."
This is what I think was intended and lets us successfully cross compile from linux and
macOS to WASI and Windows, something that was broken before where native dependencies would leak into the cross-compile.
Fixes #40