Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't look for NixOS options when module-list.nix or lib doesn't exist #80

Merged
merged 1 commit into from
May 6, 2023
Merged

Conversation

figsoda
Copy link
Contributor

@figsoda figsoda commented May 5, 2023

so nil doesn't output an error when with something like this: inputs.nixpkgs.url = "github:nix-community/nixpkgs.lib";

@oxalica
Copy link
Owner

oxalica commented May 6, 2023

Could we rely on the .version file? Seems lib.trivial.release is just reading this file.

@figsoda
Copy link
Contributor Author

figsoda commented May 6, 2023

To replace builtins.compareVersions trivial.release "22.11" >= 0? I would say yes

Though this wouldn't be the only thing I rely on since it is a popular file name: https://github.com/search?q=path%3A%2F%5E%5C.version%24%2F&type=code
I think having both .version and nixos/modules/module-list.nix would be a fairly safe bet

@oxalica oxalica merged commit 67bfe95 into oxalica:main May 6, 2023
@figsoda figsoda deleted the modules branch May 6, 2023 18:48
@oxalica
Copy link
Owner

oxalica commented May 6, 2023

I also made the input name of nixpkgs used for options configurable in 21d0870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants