Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: add overlays to flake #19

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Conversation

pleshevskiy
Copy link
Contributor

Closes #17

Copy link
Owner

@oxalica oxalica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should follow other's. We don't use prefixes.

@@ -1,5 +1,6 @@
/target
/.envrc
/.direnv
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this? direnv expects .envrc or .env.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/nix-community/nix-direnv produces derivations for the shell.

flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
@oxalica
Copy link
Owner

oxalica commented Sep 24, 2022

We could also provide a overlay.nix entry for non-flake users.

@pleshevskiy
Copy link
Contributor Author

@oxalica Can you look, please? I think I've resolved all of your points)

Copy link
Owner

@oxalica oxalica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need a rebase.

overlay.nix Outdated Show resolved Hide resolved
@pleshevskiy
Copy link
Contributor Author

rebased

@oxalica oxalica merged commit 4c77fa9 into oxalica:main Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake.nix should provide an overlay
2 participants