Driver vs Connection mixup

R/OGRSQLConnection.R

@@ -8,7 +8,8 @@
 setClass(
   "OGRSQLConnection",
   contains = "DBIConnection",
-  slots = list(DSN = "character", readonly = "logical")
+  slots = list(DSN = "character", 
+               readonly = "logical")
 )
 
 #' @rdname OGRSQLConnection-class

R/sf_ogr.R

@@ -21,9 +21,8 @@ OGRSQL <- function(){ new("OGRSQLDriver") }
 
 setMethod("dbConnect", "OGRSQLDriver",
           function(drv, DSN = "", readonly = TRUE, ...) {
-            ## FIXME: could be a new MEM dataset
             if (nchar(DSN) < 1) stop("DSN must be a valid data source name (file, connection string, url, ...)")
-            new("OGRSQLDriver", DSN = DSN,  readonly = readonly, ...)
+            new("OGRSQLConnection", DSN = DSN,  readonly = readonly, ...)
           })
 
 #' @rdname OGRSQLConnection-class
@@ -34,7 +33,6 @@ setMethod("dbDisconnect", "OGRSQLConnection", function(conn, ...) {
   conn
 })
 
-
 #' Delayed read for vector resources
 #'
 #' A lazy data frame for GDAL vector data sources. as_ogr is DBI compatible and designed to work with dplyr. 
@@ -54,20 +52,20 @@ setMethod("dbDisconnect", "OGRSQLConnection", function(conn, ...) {
 #' @return a 'tbl_OGRSQLConnection'
 #' @export
 
-as_ogr <- function(x, layer, query = NA, ignore_lyrs = "gpkg_|rtree_|sqlite_") {
+as_ogr <- function(x, layer,..., query = NA, ignore_lyrs = "gpkg_|rtree_|sqlite_") {
   UseMethod("as_ogr")
 }
 
 #' @name as_ogr
 #' @export
-as_ogr.character <- function(x, layer, query, ignore_lyrs) {
+as_ogr.character <- function(x, layer, ..., query = NA, ignore_lyrs = "gpkg_|rtree_|sqlite_") {
   db <- dbConnect(OGRSQL(), x)
-  as_ogr(db, layer, query = query, ignore_lyrs = ignore_lyrs)
+  as_ogr(db, layer, ..., query = query, ignore_lyrs = ignore_lyrs)
 }
 
 #' @name as_ogr
 #' @export
-as_ogr.OGRSQLConnection <- function(x, layer, query, ignore_lyrs) {
+as_ogr.OGRSQLConnection <- function(x, layer, ..., query = NA, ignore_lyrs = "gpkg_|rtree_|sqlite_") {
 
   if (!is.na(query)) {
     if (!missing(layer)) message("'layer' argument ignored, using 'query'")