Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LatLngs should be rounded to 6 significant figures when displayed #1279

Merged
merged 4 commits into from
Oct 19, 2022

Conversation

growse
Copy link
Collaborator

@growse growse commented Aug 26, 2022

Avoids ugly floating point recurring decimals nonsense.

Fixes #1278

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Base: 45.74% // Head: 46.00% // Increases project coverage by +0.25% 🎉

Coverage data is based on head (f41ce86) compared to base (f984043).
Patch coverage: 66.66% of modified lines in pull request are covered.

❗ Current head f41ce86 differs from pull request most recent head e3f4574. Consider uploading reports for the commit e3f4574 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1279      +/-   ##
============================================
+ Coverage     45.74%   46.00%   +0.25%     
+ Complexity     1017     1016       -1     
============================================
  Files           172      172              
  Lines          6728     6721       -7     
  Branches        686      687       +1     
============================================
+ Hits           3078     3092      +14     
+ Misses         3266     3247      -19     
+ Partials        384      382       -2     
Flag Coverage Δ
uitests 41.03% <66.66%> (+0.26%) ⬆️
unittests 14.18% <33.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...org/owntracks/android/ui/map/osm/OSMMapFragment.kt 77.48% <50.00%> (+1.09%) ⬆️
...wntracks/android/model/messages/MessageLocation.kt 91.52% <100.00%> (+0.14%) ⬆️
...rg/owntracks/android/geocoding/GeocoderLRUCache.kt 62.50% <0.00%> (-25.00%) ⬇️
...android/services/MessageProcessorEndpointHttp.java 61.93% <0.00%> (-3.23%) ⬇️
.../owntracks/android/services/LocationProcessor.java 32.32% <0.00%> (-2.03%) ⬇️
...g/owntracks/android/services/MessageProcessor.java 45.96% <0.00%> (-1.21%) ⬇️
...n/java/org/owntracks/android/ui/map/MapActivity.kt 3.02% <0.00%> (ø)
...rg/owntracks/android/ui/welcome/VersionFragment.kt 0.00% <0.00%> (ø)
...acks/android/ui/welcome/ConnectionSetupFragment.kt 0.00% <0.00%> (ø)
...n/java/org/owntracks/android/ui/map/MapFragment.kt 81.39% <0.00%> (+1.39%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@growse growse force-pushed the master branch 6 times, most recently from 442f735 to da44962 Compare September 18, 2022 13:01
@growse growse added this to the 2.4.11 milestone Sep 26, 2022
@growse growse force-pushed the master branch 4 times, most recently from 1462038 to 6d76f1b Compare October 2, 2022 15:31
@growse growse force-pushed the round-latlng-to-sensible-precision branch from f41ce86 to e3f4574 Compare October 19, 2022 14:48
@growse growse added the smoke-test-required PRs that just need a smoke test suite before merging label Oct 19, 2022
@growse growse marked this pull request as ready for review October 19, 2022 15:12
@growse growse merged commit e8c9d88 into master Oct 19, 2022
@growse growse deleted the round-latlng-to-sensible-precision branch October 19, 2022 15:12
@growse growse restored the round-latlng-to-sensible-precision branch November 2, 2022 10:56
@growse growse deleted the round-latlng-to-sensible-precision branch November 2, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-test-required PRs that just need a smoke test suite before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LatLng display should probably round to a sensible number of digits.
1 participant