Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component/choice #27

Merged
merged 22 commits into from
Dec 30, 2021
Merged

Component/choice #27

merged 22 commits into from
Dec 30, 2021

Conversation

HQCuong
Copy link
Collaborator

@HQCuong HQCuong commented Dec 29, 2021

#9

@HQCuong
Merge remote-tracking branch 'origin/component/inline-error' into com…
b5f5779 
…ponent/choice
@HQCuong
Update: add Choice component
bb21e58
@HQCuong
Fix: modify helpText slot in Choice component
f1d7b6b
@HQCuong
Fix: modify label property in Choice component
32f9551
@HQCuong
Fix: change className computed to wrapperClassName in Choice component
0c5405a
@HQCuong
Fix: use uppercase for helpTextID computed (old helpTextId)
3886345
@HQCuong
Merge remote-tracking branch 'origin/component/inline-error' into com…
c183fe0 
…ponent/choice
@HQCuong
Merge remote-tracking branch 'origin/component/inline-error' into com…
a05838b 
…ponent/choice
@HQCuong
Fix: modify type for error prop and change computed name childrenClas…
a15229b 
…s to controlClass
@HQCuong
Merge remote-tracking branch 'origin/component/inline-error' into com…
ac739b0 
…ponent/choice
@HQCuong
Update: export helpTextId in Choice component
42b9e30
@HQCuong
Merge remote-tracking branch 'origin/component/inline-error' into com…
b8fcecb 
…ponent/choice
@HQCuong
Fix: modify spelling mistake fieldId to fieldID in template
783a7df
@HQCuong
Merge remote-tracking branch 'origin/component/inline-error' into com…
a959b1c 
…ponent/choice
@HQCuong
Update: add type array, function for error prop
1447344
@HQCuong
Fix: using import type instead of import
4a167a8
@HQCuong
Merge remote-tracking branch 'origin/dev' into component/choice
09fd90b
@HQCuong
Merge remote-tracking branch 'origin/dev' into component/choice
1309a39
@HQCuong
Merge remote-tracking branch 'origin/dev' into component/choice
35048b7
@HQCuong
Update: modify part of Error type in Choice Component
53940b9
@HQCuong
Fix: remove unnecessary label prop
a0c948b
@HQCuong
Fix: remove unnecessary space char in label slot
deb3865
@HQCuong HQCuong requested a review from juzser December 29, 2021 11:38
@HQCuong HQCuong linked an issue Dec 29, 2021 that may be closed by this pull request
Choice Component #9
Closed
@juzser juzser merged commit d28f2cb into dev Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juzser juzser Awaiting requested review from juzser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Choice Component
2 participants
@HQCuong @juzser