Merge pull request #400 from ownego/fix/index-table-sticky-header

Fix/index table sticky header
ownego · Sep 6, 2024 · dea0a05 · dea0a05
2 parents 341b464 + 2252e6e
commit dea0a05
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/components/IndexTable/IndexTableBase.vue b/src/components/IndexTable/IndexTableBase.vue
@@ -596,7 +596,7 @@ function handleSortHeadingClick(
 
 // loadingMarkup
 const loadingMarkup = computed(() => {
-  return h(
+  return loading?.value && h(
     'div',
     {
       class: classNames(

diff --git a/src/components/Sticky/Sticky.vue b/src/components/Sticky/Sticky.vue
@@ -66,15 +66,16 @@ const handlePositioning = (
   width = 0,
 ) => {
   if ((stick && !isSticky.value) || (!stick && isSticky.value)) {
-    adjustPlaceHolderNode(stick);
     isSticky.value = !isSticky.value;
 
-    emits('sticky-change', isSticky.value);
+    emits('sticky-change', !isSticky.value);
 
     if (!props.boundingElement) {
       return;
     }
 
+    adjustPlaceHolderNode(stick);
+
     props.boundingElement.toggleAttribute('data-sticky-active');
   }
   style.value = stick

diff --git a/src/utilities/types.ts b/src/utilities/types.ts
@@ -1,11 +1,10 @@
-import type { Component } from 'vue';
-import type { ComputedRef, Ref } from 'vue';
+import type { Component, ComputedRef, Ref } from 'vue';
 
 export type Target = '_blank' | '_self' | '_parent' | '_top';
 
 export type IconSource = Component | string | (string | Component)[]
 
-export type VueNode = string | number | boolean | Component | Element | null | undefined;
+export type VueNode = string | number | boolean | Component | Element | Function | null | undefined;
 
 export type NonEmptyArray<T> = [T, ...T[]];