Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accentuate new files #6020

Merged
merged 1 commit into from
Nov 12, 2021
Merged

accentuate new files #6020

merged 1 commit into from
Nov 12, 2021

Conversation

fschade
Copy link
Collaborator

@fschade fschade commented Nov 11, 2021 •
edited by pascalwengerter
Loading

Description

accentuate new files/folders, new uploaded files/folders and new file versions

Related Issue

How Has This Been Tested?

  • Full unit test coverage

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Code changes
  • Unit tests added

Open tasks:

  • add unit tests for web-app-files/src/views/PublicFiles.vue (can happen in separate PR)
  • add unit tests for web-app-files/src/views/Personal.vue (can happen in separate PR)
  • add unit tests for web-app-files/src/helpers/store.ts (can happen in separate PR)

@fschade fschade mentioned this pull request Nov 11, 2021
Closed
3 tasks
@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

44.1% 44.1% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 😍

@kulmann kulmann merged commit f2e48fb into master Nov 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the accentuate-upserted-files branch November 12, 2021 07:33
@kulmann
Copy link
Member

kulmann commented Nov 12, 2021

merged to have it in - happy to get the unit tests in subsequent PRs! 🤩

@pascalwengerter pascalwengerter mentioned this pull request Nov 12, 2021
Closed
10 tasks
@kulmann kulmann mentioned this pull request Nov 12, 2021
Closed
26 tasks
@fschade fschade mentioned this pull request Nov 12, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fschade @kulmann