[full-ci] Small fixes #5985

diocas · 2021-11-05T17:51:13Z

Just a bunch of (I hope) fixes:

I've made the hidden files hidden by default. This is the current behavior in oc10 and I believe should be the same in web;
Generate sourcemap. We did this to make it easier to debug, let me know if you think this should not be pushed to production (edit: made it configurable)
~~Clean paths for drawio~~ (opened a diff PR with this fix)

Some more debatable fixes:

I've changed the default title of the html page from "owncloud" to "loading" (not translated). Ofc this changes to the configured title once the app loads, but if something fails or takes a long time to load, users get confused. (edit: made the title configurable instead)

In the same spirit, I've added information that is displayed before the app loads: ~~a loading message~~ a spinner that appears if it takes more than 1s) to load resources or an error message if something fails. When we had our performance issues, users were getting blank pages and had no idea what was happening, so a bit of feedback is positive. This is not translated, but the users only see the text on error, so it should be acceptable like this.
Fixes #5961: it doesn't improve the performance, but a least gives feedback to the user instead of a white page

pascalwengerter · 2021-11-08T09:42:47Z

@diocas could you run yarn lint --fix and commit the changes so we can see what CI says? :)

Edit: Also, it seems to have conflicting files. Could you rebase it, too?

ownclouders · 2021-11-08T14:33:22Z

Results for oC10Trashbin https://drone.owncloud.com/owncloud/web/20127/38/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

ownclouders · 2021-11-08T20:45:19Z

Results for oC10Trashbin https://drone.owncloud.com/owncloud/web/20133/38/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

ownclouders · 2021-11-09T08:15:52Z

Results for oCISSharingInternalUsers2 https://drone.owncloud.com/owncloud/web/20139/58/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

ownclouders · 2021-11-09T21:39:25Z

Results for oC10Trashbin https://drone.owncloud.com/owncloud/web/20175/38/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

ownclouders · 2021-11-10T22:23:30Z

Results for oC10Trashbin https://drone.owncloud.com/owncloud/web/20224/38/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

ownclouders · 2021-11-16T11:23:31Z

Results for oC10Trashbin https://drone.owncloud.com/owncloud/web/20307/38/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

ownclouders · 2021-11-16T11:53:59Z

Results for oC10Trashbin https://drone.owncloud.com/owncloud/web/20311/38/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

diocas · 2021-12-01T21:47:19Z

Rebased with latest master and did some changes:

When loading the app takes longer than 1s, instead of showing text, which was in english and was not translated, now I show a spinner similar to ocSpinner.
Made the title configurable (since you prob don't want "loading...", as I had before).
You separated ActionMenuItem and changed the display of icon and img to an if/else. But the else is never possible, as the icon of an app is always defined (icon: appInfo.icon || 'check_box_outline_blank'), so I inverted it.

@kulmann @pascalwengerter can this be merged? Some of it, at least?

kulmann

nice, thank you! 🚀 just some small comments, otherwise good to go.

kulmann · 2021-12-01T21:56:22Z

packages/web-app-files/src/mixins/fileActions.js

+          }
+        })
+        .sort((first, second) => {
+          // We make the default action based on the order, so put the ones who can be default first


The comment is a bit misleading. In fact the default action only picks from actions where canBeDefault evaluates to true. But it totally makes sense to have the (possible) default actions first. Otherwise a right click with multiple available actions might have an action first that is not the default. Nice catch!

Was this a recent fix? In the past, I had non default apps being used when I clicked a file. But maybe the issue was he fact that every app was having canBeDeFault as true... I'll modify the comment then.

#5970 should fix that. Could you have a look to confirm?

kulmann · 2021-12-01T21:57:38Z

packages/web-app-files/src/mixins/fileActions.js

@@ -214,7 +223,8 @@ export default {
        const label = this.$gettext('Open in %{ appName }')
        return {
          name: app.name,
-          img: app.icon,
+          icon: app.icon,


Oh, does the app provider return icon names from the design system now? 🤔 I thought the icon value from the app provider is always some image url.

For us, yes, we added the icons in ODS. But this should be unified in the app provider as well (I will check and ask for changes), as I don't think is intuitive to have them mixed.

packages/web-runtime/src/store/apps.js

phil-davis · 2021-12-02T03:27:12Z

https://drone.owncloud.com/owncloud/web/20581/9/7
Test Suites: 1 failed, 113 passed, 114 total

A unit test needs to be fixed.

diocas · 2021-12-02T11:17:44Z

@phil-davis I've changed the test. The test assumed we can delete the icon, but this is not true if you set it from the extension configuration (and since icon always has a default value...). So I removed this part and ensure that, when setting img this takes precedence over icon.

Also applied @kulmann requests and added a changelog.

kulmann · 2021-12-02T11:28:11Z

@wkloucek https://drone.owncloud.com/owncloud/web/20609/9/2 states msg="execution failed: commit from DRONE_COMMIT_BEFORE not found: object not found", could you take a look?

phil-davis · 2021-12-02T11:41:48Z

https://drone.owncloud.com/owncloud/web/20609/9/2
That's a strange drone CI fail - nothing to do with the code of this PR!

@diocas we have made a few fixes today for intermittent annoying things in CI pipelines. Please rebase to latest and force-push and you might get more joy! If it dies again the same, then @wkloucek could look or...

kulmann · 2021-12-02T14:27:01Z

restarted CI, smoke tests are flaky at the moment, sorry

ownclouders · 2021-12-02T14:48:44Z

Results for oCISBasic https://drone.owncloud.com/owncloud/web/20619/51/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

phil-davis · 2021-12-02T15:51:35Z

A smoke-test pipeline failed. I commented in issue #6082 (comment)
We are now trying to see why that pipeline is having trouble.
I restarted CI.

Edit, update: both smoke test pipelines passed this time!

ownclouders · 2021-12-02T16:14:31Z

Results for oCISBasic https://drone.owncloud.com/owncloud/web/20625/51/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

ownclouders · 2021-12-02T16:14:35Z

Results for oC10Trashbin https://drone.owncloud.com/owncloud/web/20625/40/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

phil-davis · 2021-12-02T16:51:23Z

I made PR #6088 on top of this to run full-ci and get the tests passing. If I can achieve that tomorrow morning, then I can push any fixes here to get this passing.

ownclouders · 2021-12-09T10:19:10Z

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/20826/16/1
The following scenarios passed on retry:

webUISharingAcceptSharesToRoot/acceptShares.feature:108

This title appears before the config title is loaded.

Show simple spinner (similar to ocSpiner) if it takes too long to load (> 1s); Show error message when failed to load.

Allow img instead of icon Ensure canBeDefault is honored

If there's an image, it takes precedence over icon (which always has a default)

sonarcloud · 2021-12-13T08:42:34Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

pascalwengerter · 2021-12-14T09:50:14Z

I'll merge this into a temporary PR to be able to work directly on it

diocas requested review from fschade, kulmann and pascalwengerter as code owners November 5, 2021 17:51

diocas changed the title ~~Up small fixes~~ Small fixes Nov 5, 2021

diocas added the Early-Adopter:CERN label Nov 5, 2021

diocas mentioned this pull request Nov 7, 2021

Performance: blank page because of timeout #5957

Closed

diocas force-pushed the up_small_fixes branch from 9521a56 to c6f0665 Compare November 8, 2021 14:15

diocas force-pushed the up_small_fixes branch from c6f0665 to 11c0a2f Compare November 8, 2021 20:20

diocas force-pushed the up_small_fixes branch from 5bf56b2 to 11c0a2f Compare November 9, 2021 08:05

diocas force-pushed the up_small_fixes branch from 11c0a2f to 0ae0078 Compare November 9, 2021 21:14

diocas force-pushed the up_small_fixes branch from 0ae0078 to 6662a72 Compare November 10, 2021 21:51

diocas force-pushed the up_small_fixes branch from 6662a72 to 6ff3a5b Compare November 16, 2021 10:52

diocas force-pushed the up_small_fixes branch from 6ff3a5b to c62f757 Compare November 16, 2021 11:30

diocas force-pushed the up_small_fixes branch from c62f757 to ae973fe Compare December 1, 2021 21:42

diocas force-pushed the up_small_fixes branch from ae973fe to 1d3f577 Compare December 1, 2021 21:55

kulmann requested changes Dec 1, 2021

View reviewed changes

diocas force-pushed the up_small_fixes branch from 1d3f577 to a36e99b Compare December 2, 2021 11:14

owncloud deleted a comment from update-docs bot Dec 2, 2021

phil-davis requested a review from kulmann December 2, 2021 16:08

kulmann approved these changes Dec 2, 2021

View reviewed changes

phil-davis changed the title ~~Small fixes~~ [full-ci] Small fixes Dec 2, 2021

phil-davis mentioned this pull request Dec 2, 2021

[full-ci] Small fixes tests #6088

Closed

diocas force-pushed the up_small_fixes branch from 902800a to 8362a44 Compare December 9, 2021 09:51

diocas added 8 commits December 10, 2021 19:15

Hide hidden files by default

45213e2

Make default title configurable

a74bf79

This title appears before the config title is loaded.

Optional sourcemaps

2a6a18b

Change login message

21716f1

Feedback while loading the app

f8c8be8

Show simple spinner (similar to ocSpiner) if it takes too long to load (> 1s); Show error message when failed to load.

Apps fixes

8782612

Allow img instead of icon Ensure canBeDefault is honored

Update tests for app img display

54ea46a

If there's an image, it takes precedence over icon (which always has a default)

Changelog

6c738c7

diocas force-pushed the up_small_fixes branch from 8362a44 to 6c738c7 Compare December 10, 2021 18:23

pascalwengerter changed the base branch from master to small-cern-fixes December 14, 2021 09:49

pascalwengerter merged commit 85355f7 into owncloud:small-cern-fixes Dec 14, 2021

diocas deleted the up_small_fixes branch December 14, 2021 19:28

pascalwengerter mentioned this pull request Dec 22, 2021

Release 4.8.0 #6178

Closed

22 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[full-ci] Small fixes #5985

[full-ci] Small fixes #5985

diocas commented Nov 5, 2021 •

edited

Loading

pascalwengerter commented Nov 8, 2021 •

edited

Loading

ownclouders commented Nov 8, 2021

ownclouders commented Nov 8, 2021

ownclouders commented Nov 9, 2021

ownclouders commented Nov 9, 2021

ownclouders commented Nov 10, 2021

ownclouders commented Nov 16, 2021

ownclouders commented Nov 16, 2021

diocas commented Dec 1, 2021 •

edited

Loading

kulmann left a comment

kulmann Dec 1, 2021

diocas Dec 2, 2021

kulmann Dec 2, 2021

kulmann Dec 1, 2021

diocas Dec 2, 2021

phil-davis commented Dec 2, 2021

diocas commented Dec 2, 2021

kulmann commented Dec 2, 2021

phil-davis commented Dec 2, 2021

kulmann commented Dec 2, 2021

ownclouders commented Dec 2, 2021

phil-davis commented Dec 2, 2021 •

edited

Loading

ownclouders commented Dec 2, 2021

ownclouders commented Dec 2, 2021

phil-davis commented Dec 2, 2021

ownclouders commented Dec 9, 2021

sonarcloud bot commented Dec 13, 2021

pascalwengerter commented Dec 14, 2021

[full-ci] Small fixes #5985

[full-ci] Small fixes #5985

Conversation

diocas commented Nov 5, 2021 • edited Loading

pascalwengerter commented Nov 8, 2021 • edited Loading

ownclouders commented Nov 8, 2021

ownclouders commented Nov 8, 2021

ownclouders commented Nov 9, 2021

ownclouders commented Nov 9, 2021

ownclouders commented Nov 10, 2021

ownclouders commented Nov 16, 2021

ownclouders commented Nov 16, 2021

diocas commented Dec 1, 2021 • edited Loading

kulmann left a comment

Choose a reason for hiding this comment

kulmann Dec 1, 2021

Choose a reason for hiding this comment

diocas Dec 2, 2021

Choose a reason for hiding this comment

kulmann Dec 2, 2021

Choose a reason for hiding this comment

kulmann Dec 1, 2021

Choose a reason for hiding this comment

diocas Dec 2, 2021

Choose a reason for hiding this comment

phil-davis commented Dec 2, 2021

diocas commented Dec 2, 2021

kulmann commented Dec 2, 2021

phil-davis commented Dec 2, 2021

kulmann commented Dec 2, 2021

ownclouders commented Dec 2, 2021

phil-davis commented Dec 2, 2021 • edited Loading

ownclouders commented Dec 2, 2021

ownclouders commented Dec 2, 2021

phil-davis commented Dec 2, 2021

ownclouders commented Dec 9, 2021

sonarcloud bot commented Dec 13, 2021

pascalwengerter commented Dec 14, 2021

diocas commented Nov 5, 2021 •

edited

Loading

pascalwengerter commented Nov 8, 2021 •

edited

Loading

diocas commented Dec 1, 2021 •

edited

Loading

phil-davis commented Dec 2, 2021 •

edited

Loading