Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP public link separate token from path #2408

Closed
wants to merge 4 commits into from

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Nov 7, 2019

This was an attempt based on #2239 to separate the token from the path in public link. However this seems to be a rabbit hole that needs more attention later.

I'm leaving it in this PR for now for later reference / recycling.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Vincent Petry seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kulmann
Copy link
Member

kulmann commented Jun 25, 2021

Thanks for leaving this here! :-) Has been solved "already" during the last 1,5 years. Closing.

@kulmann kulmann closed this Jun 25, 2021
@pascalwengerter pascalwengerter deleted the publiclink-separate-token-and-item branch June 29, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants