-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File browser #165
File browser #165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does what's expected.
@@ -249,6 +253,17 @@ | |||
}, | |||
isChecked(item) { | |||
return _.includes(this.selected, item); | |||
}, | |||
onDrop(dropLocation, dropData, dragData, event) { | |||
if(dropLocation === 'file-list' && dropData.type === 'folder'){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, works fine but some UI changes would make it better. Can be a part of a different PR.
Let's how the code looks after merging.
Conflicts. Please resolve |
This PR needs some adjustment to work with the new approach. Moving the store to the global store ect. |
@OshanIvantha it might be easiest to take the changes and apply them in a new branch off of master. We need to test how to use the vue-drag-drop plugin without attaching it to the vue instance. |
@felixheidecke These implementations are reapplied in #216 |
Implement moving files by drag and drop (#150)