Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File browser #165

Closed
wants to merge 4 commits into from
Closed

File browser #165

wants to merge 4 commits into from

Conversation

ivantha
Copy link
Contributor

@ivantha ivantha commented Jun 27, 2018

Implement moving files by drag and drop (#150)

  • move selected entries to subfolder with drag and drop
  • drag to breadcrumb to move to parent folder

Copy link
Contributor

@felixheidecke felixheidecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does what's expected.

@@ -249,6 +253,17 @@
},
isChecked(item) {
return _.includes(this.selected, item);
},
onDrop(dropLocation, dropData, dragData, event) {
if(dropLocation === 'file-list' && dropData.type === 'folder'){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent

Copy link
Contributor

@felixheidecke felixheidecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, works fine but some UI changes would make it better. Can be a part of a different PR.
Let's how the code looks after merging.

@DeepDiver1975
Copy link
Member

Conflicts. Please resolve

@felixheidecke
Copy link
Contributor

This PR needs some adjustment to work with the new approach. Moving the store to the global store ect.

@felixheidecke
Copy link
Contributor

@OshanIvantha it might be easiest to take the changes and apply them in a new branch off of master. We need to test how to use the vue-drag-drop plugin without attaching it to the vue instance.

@ivantha ivantha mentioned this pull request Aug 12, 2018
6 tasks
@ivantha
Copy link
Contributor Author

ivantha commented Aug 12, 2018

@felixheidecke These implementations are reapplied in #216
The issue of using vue-drag-drop plugin without attaching it to the Vue instance has yet to be resolved.

@ivantha ivantha closed this Aug 12, 2018
@ivantha ivantha deleted the file-browser branch August 12, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants