Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): focus trap for contextual helpers #11574

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Sep 12, 2024

Description

Adds a focus trap to contextual helpers to prevent the user from focusing elements in the background.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Sep 12, 2024
@JammingBen JammingBen force-pushed the fix/contextual-helper-focus-trap branch from be1a061 to 21e3ec3 Compare September 12, 2024 12:09
@JammingBen JammingBen marked this pull request as ready for review September 12, 2024 12:30
@JammingBen JammingBen force-pushed the fix/contextual-helper-focus-trap branch 2 times, most recently from e413a97 to 0f0aff6 Compare September 13, 2024 06:23
Adds a focus trap to contextual helpers to prevent the user from focusing elements in the background.
@JammingBen JammingBen force-pushed the fix/contextual-helper-focus-trap branch from 0f0aff6 to 93e21e7 Compare September 13, 2024 06:24
Copy link

sonarcloud bot commented Sep 13, 2024

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🥇

@JammingBen JammingBen merged commit 95e8d75 into master Sep 13, 2024
3 checks passed
@JammingBen JammingBen deleted the fix/contextual-helper-focus-trap branch September 13, 2024 07:15
@micbar micbar mentioned this pull request Oct 1, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants